Re: svn commit: r30205 - trunk/notes

On Wed, Apr 2, 2008 at 8:44 PM, David Glasser <glasser_at_davidglasser.net> wrote:
> On Wed, Apr 2, 2008 at 3:37 PM, <kfogel_at_tigris.org> wrote:
> > Author: kfogel
> > Date: Wed Apr 2 15:37:52 2008
> > New Revision: 30205
> >
> > Log:
> > * notes/sparse-directories.txt: Bring up to date.
>
>
>
> > On the client side, most of the svn_client.h interfaces that
> > - formerly took 'svn_boolean_t recurse' now take 'svn_depth_t depth'.
> > - (The -N option is deprecated, but it still works: it simply maps to
> > - --depth=files, which results in the same behavior as -N used to.)
> > + formerly took 'svn_boolean_t recurse' have been revved and their
> > + successors take 'svn_depth_t depth' instead. (The -N option is
> > + deprecated, but it still works: it simply maps to --depth=files,
> > + which results in the same behavior as -N used to.)
>
> Isn't it actually "-N maps to --depth=files, empty, or immediates,
> depending on context, for compatibility"? (I think it's immediates
> for status, empty for revert and add, and files for everything else,
> or something.)

Though actually it varies. In the CLI, -N does what I described. But
various other layers translate recurse to depth differently. eg, the
"add" exception doesn't exist in svn_client_add3. In svnserve's
'status' handler, non-recursive goes to empty. Etc.

I think we need to go back to what we had before where the conversion
macro has a clear role name:

SVN_DEPTH_FROM_RECURSE_FOR_STATUS
SVN_DEPTH_FROM_RECURSE_FOR_REVERT_OR_ADD
SVN_DEPTH_FROM_RECURSE

Then it's absolutely obvious if a given use of the macro is consistent
or not. The status quo is a mess.

(Unless there's some reason that the special-casing of these
operations should be different at the UI, the client API, and the RA
API levels?)

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org