[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r29961 - in trunk/subversion: include libsvn_client

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: Wed, 02 Apr 2008 12:49:38 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bhuvaneswaran A wrote:
> On Wed, 2008-04-02 at 12:31 +0530, Kamesh Jayachandran wrote:
>>>> * subversion/include/svn_client.h
>>>> (SVN_CLIENT_IS_WC_DEPENDENT_REVKIND): Move this macro ...
>>>> * subversion/libsvn_client/client.h
>>>> (SVN_CLIENT__REVKIND_NEEDS_WC) ... to here and rename it.
>> I just realized do we need SVN_CLIENT__REVKIND_NEEDS_WC at all as we
>> already have svn_client__revision_is_local?
>
> If i'm right, in SVN_CLIENT__REVKIND_NEEDS_WC macro, we check for
> following revisions:
> svn_opt_revision_base
> svn_opt_revision_previous
> svn_opt_revision_working
> svn_opt_revision_committed
>
> whereas, in svn_client__revision_is_local() function we check for
> following revisions:
> svn_opt_revision_unspecified
> svn_opt_revision_head
> svn_opt_revision_number
> svn_opt_revision_date

See the return value 'svn_client__revision_is_local' returns FALSE if
revisionkind belongs to anyone of {unspecified, head, number, date}
otherwise(base, previous, working, committed) returns TRUE same as
SVN_CLIENT__REVKIND_NEEDS_WC.

With regards
Kamesh Jayachandran
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH8zOK3WHvyO0YTCwRAvnqAJ9w/6XSrjIGsyjuW0ZFuQBWelueKwCeM1rn
JUSO9kAIB/SANCDVgZrA7qs=
=wqtr
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-02 09:20:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.