[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.5 Neon bug in copy-on-update

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Tue, 01 Apr 2008 20:17:49 +0200

David Glasser wrote:
> Here's today's episode of "Subversion WebDAV RA tries to be too smart
> for its own good instead of just serializing RA API calls like
> ra_svn"!
>
> Before 1.5, server never sent add-with-history to clients, so it would
> never make sense for a "remove prop" XML element to be inside an "add
> file" element.
>
> And in fact, libsvn_ra_neon/fetch.c(validate_element) tries to
> validate this, throwing a corrupted XML error if (among many other
> things) an ELEM_remove_prop is inside an ELEM_add_file. This breaks
> the update. (Similar issues presumably include remove-prop inside
> add-directory, and delete-entry inside add-directory, but perhaps many
> more combinations as well.)
>
> To reproduce, do something like:
>
> $ svn ps foo bar a
> $ svn ci
> Revision 10.
> $ svn cp a b
> $ svn pd foo b
> $ svn ci
> Revision 11.
> $ svn up -r10
> $ svn up -r11
>
> I have no idea if serf has this bug; I've just verified that ra_svn
> and ra_local don't.

I can reproduce this issue with ra_neon, but not with ra_serf. I didn't
look very deeply into it but at first sight I see that ra_serf is just
fetching the content of the copied file from the repo, not from the
working copy.

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-04-01 20:18:02 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.