Re: [PATCH] commit-email.pl: support subject line based on log message

On Mon, Mar 31, 2008 at 03:39:44PM -0700, David Glasser wrote:
> 2008/3/28 Gregory Nathan Price <price_at_mit.edu>:
> > [[[
> > * tools/hook-scripts/commit-email.pl.in
> > Support --summary for taking subject line from log message.
> >
> > Patch by: Greg Price <price_at_mit.edu>
> > ]]]
>
> Looks reasonable to me. However, instead of:
>
> chop(my $summary = $log[0]);
>
> how about
>
> my $summary = @log ? $log[0] : '';
> chop $summary;
>
> ?

Sure. New patch attached with this change.

I also switched to chomp per the thread's further discussion, though
in the present code it makes no difference; from where @log is created
on line 368, it's clear every element ends with a newline.

Greg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org