2008/3/28, Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>:
> I haven't reviewed the patch, but it would be more useful if it:
> a) was in unified diff format
> b) was against a trunk working copy instead of a beta tarball
> c) had an accompanying log message to explain the change
Thanks!
New attempt follows:
Proposed Log message:
Allow browser navigation from repository top to repository list
when SVNListParentPath is on.
Reproduction recipe.
- Go with your browser (IE or any other) to the top of any svn repository
where SVNListParentPath is set to on, e.g.:
<http://svn.webwideconsulting.com/plugins/friendship_plugin/>
- Note that the super-directory (/plugins/) is browsable as well, but
you cannot navigate to it from here.
- I would expect that the first entry of the list is a hyperlinked "..",
which would navigate to its super-directory.
I checked this with the trunk, and the buglet is still there.
Rationale: in repos.c, the decision whether to include the link or not
is based on two things:
- If repos_path is of length 1 (so it must be "/"), then skip this step
- If the collection is of type DAV_SVN_RESTYPE_PARENTPATH_COLLECTION
(the highest browsable directory), then skip this step too.
This can be fixed by ignoring the first condition when SVNListParentPath is on.
Unfortunately I don't have an environment set up to build mod_dav_svn to test
this, but I'm pretty confident that this fix will work (for what's worth).
Can I file an issue for this? See patch below.
Regards,
Jan Nijtmans
Here is the patch against svn trunk in unified diff (I re-ordered it
a little because
dav_svn__get_list_parentpath_flag() is a more expensive test, so it should
be done last):
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-28 16:00:54 CET