Re: [PATCH] set_up_diff_cmd_and_options() doesn't accept NULL config

Hi,

2008/3/28, Senthil Kumaran S <senthil_at_collab.net>:
> Kouhei Sutou wrote:
>
> > set_up_diff_cmd_and_options()'s document says:
> >
> > /* Initialize DIFF_CMD_BATON.diff_cmd and DIFF_CMD_BATON.options,
> > * according to OPTIONS and CONFIG. CONFIG may be null.
> > * Allocate the fields in POOL, which should be at least as long-lived
> > * as the pool DIFF_CMD_BATON itself is allocated in.
> > */
> >
> > But it doesn't accept NULL as CONFIG.
> >
>
> Can you explain which does not accept NULL as CONFIG?

I think CONFIG in the document means "apr_hash_t *config". And
I noticed that if CONFIG is NULL set_up_diff_cmd_and_options()
causes SEGV.

/* Initialize DIFF_CMD_BATON.diff_cmd and DIFF_CMD_BATON.options,
 * according to OPTIONS and CONFIG. CONFIG may be null.
 * Allocate the fields in POOL, which should be at least as long-lived
 * as the pool DIFF_CMD_BATON itself is allocated in.
 */
static svn_error_t *
set_up_diff_cmd_and_options(struct diff_cmd_baton *diff_cmd_baton,
                            const apr_array_header_t *options,
                            apr_hash_t *config, apr_pool_t *pool)

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org