[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r29578 - trunk/subversion/mod_dav_svn/reports

From: Paul Burba <ptburba_at_gmail.com>
Date: Wed, 19 Mar 2008 14:42:08 -0400

On Sun, Feb 24, 2008 at 8:07 AM, <dionisos_at_tigris.org> wrote:
> Author: dionisos
> Date: Sun Feb 24 04:07:22 2008
> New Revision: 29578
>
> Log:
> Destroy a pool after use.
>
> * subversion/mod_dav_svn/reports/log.c
> (log_receiver): When creating a pool, destroy it after use.
>
>
> Modified:
> trunk/subversion/mod_dav_svn/reports/log.c
>
> Modified: trunk/subversion/mod_dav_svn/reports/log.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/mod_dav_svn/reports/log.c?pathrev=29578&r1=29577&r2=29578
> ==============================================================================
> --- trunk/subversion/mod_dav_svn/reports/log.c (original)
> +++ trunk/subversion/mod_dav_svn/reports/log.c Sun Feb 24 04:07:22 2008
> @@ -237,6 +237,8 @@
> }
> }
>
> + svn_pool_destroy(iterpool);
> +
> SVN_ERR(dav_svn__send_xml(lrb->bb, lrb->output, "</S:log-item>" DEBUG_CR));

Hi Erik,

The test suite on Windows fails over ra_neon since this change. A
simple reproduction: Checkout an empty repository, add a directory,
then do a URL->WC copy of the directory:

>set url=http://localhost/svn-test-work/repositories/REPOS

>svnadmin create ..\repositories\REPOS

>svn co %url% WC
Checked out revision 0.

>mkdir WC\dir

>svn add wc\dir
A WC\dir

>svn ci WC -m ""
Adding WC\dir

Committed revision 1.

>svn copy %url%/dir WC\dir_copy
Checked out revision 1.
A WC\dir_copy
..\..\..\subversion\libsvn_ra_neon\util.c:601: (apr_err=175002)
svn: REPORT of '/svn-test-work/repositories/REPOS/!svn/bc/0': Could
not read status line: An existing connection was forcibly closed by
the remote host.
(http://localhost)

It's not just this change though, it has been back-ported to 1.5.x and
that is working fine for me. Trying to figure out what is wrong, but
if you have any thoughts they'd be appreciated.

Paul

P.S. Can anyone with a Win32 box replicate this problem?

> return SVN_NO_ERROR;
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe_at_subversion.tigris.org
> For additional commands, e-mail: svn-help_at_subversion.tigris.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-19 19:42:20 CET

This is an archived mail posted to the Subversion Dev mailing list.