[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r29939 - in trunk/subversion: include libsvn_ra_serf

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Mon, 17 Mar 2008 18:58:33 +0100

Karl Fogel wrote:
> "Arfrever Frehtes Taifersar Arahesis" <arfrever.fta_at_gmail.com> writes:
>>> --- trunk/subversion/libsvn_ra_serf/util.c Sun Mar 16 13:26:00 2008 (r29938)
>>> +++ trunk/subversion/libsvn_ra_serf/util.c Sun Mar 16 18:27:54 2008 (r29939)
>>> @@ -41,6 +42,145 @@
>>> #define XML_STATUS_ERROR 0
>>> #endif
>>>
>>> +static const apr_uint32_t serf_failure_map[][2] =
>>> +{
>>> + { SERF_SSL_CERT_NOTYETVALID, SVN_AUTH_SSL_NOTYETVALID },
>>> + { SERF_SSL_CERT_EXPIRED, SVN_AUTH_SSL_EXPIRED },
>>> + { SERF_SSL_CERT_SELF_SIGNED, SVN_AUTH_SSL_UNKNOWNCA },
>>> + { SERF_SSL_CERT_UNKNOWNCA, SVN_AUTH_SSL_UNKNOWNCA }
>>> +};
>>> +
>>> +/* Convert neon's SSL failure mask to our own failure mask. */
>> "neon"
>
> Did you accidentally send the mail early? :-)
>
> I was kind of puzzled by this one-word review comment, since he does
> write "neon" in the original commit -- well, "neon's", but that makes
> sense in context.

Since this is a patch for ra_serf, I assume Arfrever means this comment
should talk about ra_serf instead of neon.

Deng, now everyone knows from where I copied this part of the patch :)

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-17 18:58:23 CET

This is an archived mail posted to the Subversion Dev mailing list.