Re: Branch 1.5.x: mod_dav_svn restricts third-party Subversion clients too much.

Alexander Kitaev wrote:
> Hello,
>
> There is the following code in subversion/mod_dav_svn/repos.c:1643
>
> if (val && (ap_strstr_c(val, "SVN/") == val))
> {
> repos->is_svn_client = TRUE;
>
> /* Client capabilities are self-reported. There is no
> guarantee the client actually has the capabilities it says
> it has, we just assume it is in the client's interests to
> report accurately. Also, we only remember the capabilities
> the server cares about (even though the client may send
> more than that). */
> ....
> }
>
> SVNKit honestly sends "SVNKit ..." User-Agent header and as a result
> capabilities reported by SVNKit are ignored by mod_dav_svn. Could the
> condition above be changed to:
>
> if (val && (ap_strstr_c(val, "SVN") == val))
>
> So far we have to use SVN/Kit for User-Agent HTTP header value.
> Thanks!

Subversion 1.5 allows clients to modify the user-agent string so it can
include the actual client used.

Check the 'client_name' member of svn_client_ctx_t in the file
http://svn.collab.net/repos/svn/branches/1.5.x/subversion/include/svn_client.h

I think SVNKit should do it the same way as Subversion 1.5.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net