[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Consistent error codes from RA layers

From: David Glasser <glasser_at_davidglasser.net>
Date: Thu, 6 Mar 2008 08:37:31 -0800

On Thu, Mar 6, 2008 at 7:55 AM, Paul Burba <ptburba_at_gmail.com> wrote:
> On Thu, Mar 6, 2008 at 5:25 AM, Julian Foad <julianfoad_at_btopenworld.com> wrote:
> > Code like this appears in several places:
> >
> > > err = editor->delete_entry(path, item->revision, parent_baton, pool);
> > > if (err)
> > > {
> > > if (err->apr_err == SVN_ERR_FS_NOT_FOUND
> > > || err->apr_err == SVN_ERR_RA_DAV_PATH_NOT_FOUND)
> >
> > These two errors both mean "the item was not present in the repository". When
> > committing to the repository, this indicates that the WC is out of date w.r.t.
> > the repository.
> >
> > SVN_ERR_FS_NOT_FOUND is sent by the file or svn RA layers, and
> > SVN_ERR_RA_DAV_PATH_NOT_FOUND is sent by the http/https RA layers, with the
> > same meaning.
>
> Julian,
>
> Thanks, this reminded me of a similar case a couple of months ago --
> which I subsequently forgot about :-(
>
> There the problem is with
>
> svn_ra_get_locations(svn_ra_session_t *session,
> apr_hash_t **locations,
> const char *path,
> svn_revnum_t peg_revision,
> apr_array_header_t *location_revisions,
> apr_pool_t *pool)
>
> If PATH doesn't exist at PEG_REVISION:
>
> RA_LOCAL/RA_SVN: Returns SVN_ERR_FS_NOT_FOUND
> RA_NEON: Returns two SVN_ERR_RA_DAV_PATH_NOT_FOUND errors
> RA_SERF: Returns SVN_NO_ERROR, sets *LOCATIONS to an empty hash.

That seems like a blatant serf bug to me

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-03-06 17:38:03 CET

This is an archived mail posted to the Subversion Dev mailing list.