[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Fix the comparison between lists in the command-line client tests

From: jeremy hinds <jeremy.hinds_at_gmail.com>
Date: Thu, 28 Feb 2008 16:09:35 -0500

This patch corrects a couple of bad list comparisons in the
commandline client test code (as discussed here:
http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=135568).
It doesn't change whether a test fails, just where in the code the
exception is raised.

[[[
Fix the comparison between lists in the command-line client tests.

* subversion/tests/cmdline/svntest/actions.py
 (run_and_verify_svn, run_and_verify_svn_match_any): use "!=" instead
 of "is not" to compare lists.
]]]

Index: subversion/tests/cmdline/svntest/actions.py
===================================================================
--- subversion/tests/cmdline/svntest/actions.py (revision 29616)
+++ subversion/tests/cmdline/svntest/actions.py (working copy)
@@ -169,7 +169,7 @@
     raise verify.SVNIncorrectDatatype("expected_stderr must not be None")

   want_err = None
- if expected_stderr is not None and expected_stderr is not []:
+ if expected_stderr is not None and expected_stderr != []:
     want_err = True

   out, err = main.run_svn(want_err, *varargs)
@@ -185,7 +185,7 @@
     raise verify.SVNIncorrectDatatype("expected_stderr must not be None")

   want_err = None
- if expected_stderr is not None and expected_stderr is not []:
+ if expected_stderr is not None and expected_stderr != []:
     want_err = True

   out, err = main.run_svn(want_err, *varargs)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-28 22:09:46 CET

This is an archived mail posted to the Subversion Dev mailing list.