jeremy hinds wrote:
> I will be posting an updated patch in a separate email. While working
> on it, I found a couple of things that I wanted to bring up:
>
> 1) In cmdline/svntest/main.py (function: run_one), there is a comment
> that says "don't trust the exitcode [from spawn_process()], will not
> be correct on Windows". Python docs say that wait() is supported on
> Unix only, so this may be the reason. I'll try to dig around for more
> info, but if exit codes cannot be reliably gotten on Windows, must I
> wrap a check against "main.is_posix_os()" around the exit-code
> verification?
Yes, if that's the case you will have to do something like that.
> 2) There is an existing passage in run_and_verify_svn() that reads:
>
> want_err = None
> if expected_stderr is not None and expected_stderr is not []:
> want_err = True
>
> I'm pretty sure this is a bug, and the second condition should be
> "expected_stderr != []". ("[] is not []" returns true.) But the
> effect appears to be that the place where the test fails is moved from
> main.run_command_stdin() to verify.verify_outputs(), so it probably
> isn't too big of a deal. Still, should I provide a separate patch for
> this?
Yes, please provide a separate patch to fix that. (I see that "not []" occurs
twice in that file, so presumably both places should be corrected.)
Thanks.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-28 19:25:22 CET