[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #3108: "svn changelist clname" does nothin

From: Daniel Shahaf <d.s_at_daniel.shahaf.co.il>
Date: Wed, 27 Feb 2008 18:07:56 +0200 (Jerusalem Standard Time)

David Glasser wrote on Tue, 26 Feb 2008 at 15:34 -0800:
> On Tue, Feb 26, 2008 at 3:16 PM, Daniel Shahaf <d.s_at_daniel.shahaf.co.il> wrote:
>> David Glasser wrote on Tue, 26 Feb 2008 at 13:10 -0800:
>> > Hmm. I kind of feel like "svn changelist" should default to
>> > svn_depth_infinite rather than svn_depth_empty. Then (a) "svn cl new
>> > --cl old" lets you do a rename, without need an extra "-R"
>>
>> I think svn_depth_empty would be a better default if dirs can be members
>> of changelists (otherwise, every changelist-operation on the dir applies
>> to its children too). I agree svn_depth_infinite is a better default if
>> dirs cannot be members of changelists.
>
> They can't be at the moment.
>
> I'm OK with, if a future version decides to allow directories on
> changelists, making people use "svn cl --depth=empty name dir" to put
> the directory on it (or -N).
>
>> > and (b)
>> > "svn cl clname directory" will add the directory's recursive contents
>> > to clname instead of just doing *nothing*.
>> >
>>
>> If all the dir's children should be in a changelist, why not pass that
>> dir as an argument on the commandline, avoiding changelists altogether?
>
> Because they might not be committing for a while...
>

Okay.

Do you think the directory should be given explicitly in this usage?
Otherwise, plain 'svn cl NAME' would recursively remove all files in the
current directory from their changelists.

>> > (If this change doesn't happen, perhaps a warning (ie, notification)
>> > that a directory is being skipped would be useful.)
>> >
>>
>> +1 (moral support).
>>

I will prepare a new patch, then, implementing 'svn_depth_infinite' as
default and 'skip' notifications.

Thanks for the review, David.

Daniel

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-27 17:37:20 CET

This is an archived mail posted to the Subversion Dev mailing list.