[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add URL support for propset and propdel and fix URL support for propedit

From: <kmradke_at_rockwellcollins.com>
Date: Mon, 25 Feb 2008 12:07:58 -0600

"C. Michael Pilato" <cmpilato_at_collab.net> wrote on 02/25/2008 11:56:25 AM:
> C. Michael Pilato wrote:
> > kmradke_at_rockwellcollins.com wrote:
> >>> Yes, that is how propedit-on-URL support works. Implementing this
> >>> feature is as simple as passing the right base_revision_for_url
> >>> argument to svn_client_propset3.
> >>
> >> By "right" you mean the HEAD revision, right? Since I was getting
> >> errors when I passed in anything else...
> >
> > By "right" he means the base revision value we've been talking about,
> > which defaults to HEAD but can be overridden at the command-line using

> > this new --base-rev (which by the way I think should be
> > "--base-revision") parameter's value.
>
> To clarify, we're saying that you needn't write a single line of code
that
> fetches the old prop value and does comparison to the new. It is not
the
> client's responsibility to detect out-of-dateness. It is the client's
> responsibility to accurately report based-on revisions and the changes
it
> wishes to commit, and leave out-of-dateness checks to the server.

I'll retest to make sure sending in a non-HEAD base revision that
hasn't had property changes since the specified base revision allows
the commit. If not, I guess this will be an even bigger patch.

What about a test to make sure the property exists before deleting it?
The current lib routines will allow you to make no-op propdel commits...

Kevin R.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-25 19:07:52 CET

This is an archived mail posted to the Subversion Dev mailing list.