[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add URL support for propset and propdel and fix URL support for propedit

From: <kmradke_at_rockwellcollins.com>
Date: Fri, 22 Feb 2008 13:44:35 -0600

"Mark Phippard" <markphip_at_gmail.com> wrote on 02/22/2008 01:34:23 PM:
> 2008/2/22 Kevin Radke <kmradke_at_gmail.com>:
> > This is my first attempt at a patch to add URL support to the propset
> > and propdel subcommands of svn. In doing so, I also noticed that
> > propedit did not support multiple URL arguments correctly.
> >
> > I needed URL functionality for propdel, since we had a repository
which
> > had the svn:special property set for a file that was not special. I
was
> > unable to create a working copy with this file due to this error, and
> > I was also unable to delete the property since you previously needed
> > a working copy to delete properties. I was able to use this modified
> > propdel to delete the incorrect property directly in the repository.
>
> What is the stuff about the -r parameter for? We would never allow
> you to go back in time and delete or edit a property, only HEAD. Is
> it being used for some other purpose?
>
> I am just going by the email, have not looked at the patch.

Needed a way to specify a "base revision", because of the possible
race condition between looking at the properties and then
performing a command directly on the repository.

We kicked around a --base-rev parameter in another thread, but
it was easier for me to "overload" the meaning of -r here.

Not using -r and using some other parameter is definitely a
(probably less confusing) option.

We could also assume "HEAD" (others didn't like this)

Is peg revision syntax appropriate? (no idea on this)

Kevin R.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-22 20:44:15 CET

This is an archived mail posted to the Subversion Dev mailing list.