[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix svnadmin verify to fully verify a revision

From: Eric Gillespie <epg_at_google.com>
Date: Wed, 13 Feb 2008 13:23:12 -0800

Gmail users, you probably need to look to your spam folder to
find my original post. I have no idea why.

Eric Gillespie <epg_at_google.com> writes:

> Index: subversion/include/svn_repos.h
> ===================================================================
> +/**
> * Dump the contents of the filesystem within already-open @a repos into
> * writable @a dumpstream. Begin at revision @a start_rev, and dump every
> * revision up through @a end_rev. Use @a pool for all allocation. If
> - * non-_at_c NULL, send feedback to @a feedback_stream. @a dumpstream can be
> - * @c NULL for the purpose of verifying the repository.
> + * non-_at_c NULL, send feedback to @a feedback_stream. If @a dumpstream is
> +
> + * @c NULL, this is effectively a primitive verify. It is not complete,
> + * however; see svn_fs_verify instead.
> *
> * If @a start_rev is @c SVN_INVALID_REVNUM, then start dumping at revision
> * 0. If @a end_rev is @c SVN_INVALID_REVNUM, then dump through the @c HEAD

Oops, I added an extraneous newline now. Fixed in my wc.

> Index: subversion/libsvn_fs_fs/fs_fs.c
> ===================================================================
> --- subversion/libsvn_fs_fs/fs_fs.c (revision 29279)
> +++ subversion/libsvn_fs_fs/fs_fs.c (working copy)
> @@ -1610,6 +1610,10 @@
>
> /* Read the node-rev id. */
> value = apr_hash_get(headers, HEADER_ID, APR_HASH_KEY_STRING);
> + if (value == NULL)
> + return svn_error_create(SVN_ERR_FS_CORRUPT, NULL,
> + _("Found malformed header in "
> + "revision file"));
>
> SVN_ERR(svn_io_file_close(revision_file, pool));
>

This error message sucks, of course. But guess what, so do the
rest in this file; I just matched those. We have a separate
patch lying around here to provide more information (the revs
file and the offset within). After this goes in, Dan Christian
or I will send in a patch polishing up all the error messages.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-13 22:23:25 CET

This is an archived mail posted to the Subversion Dev mailing list.