Re: [PATCH] Don't blow out scrollback in conflict handler prompt diff

=?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane_at_xbc.nu> writes:

> The isatty hack should be in APR; at least we should make an apr-like
> function to do that and submit it for inclusion in APR. This way ... is
> not nice.

So, I'm pretty sure the only way APR is going to want this is if
I add a function to tell if an apr_file_t is a tty. Maybe that's
useful, but it seems ridiculous to me to create an apr_file_t for
no other reason than to ask if it's a tty, and then just throw it
away (and in some cases, turn around and create another one via
svn_stream_for_stdout.

So, I'm reluctant to go that route, but I can do it if this is
going to block this change going in. Also, I can break this bit
out into svn_io_isatty and have it take a FILE * even though that
won't end up going back into apr, if you like.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-12 02:13:23 CET