[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r29175 - in trunk/subversion: libsvn_fs_fs tests/cmdline

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Thu, 07 Feb 2008 22:51:19 -0500

"David Glasser" <glasser_at_davidglasser.net> writes:
>> Log:
>> Fix issue #2992: make 'svnadmin recover' warier for FSFS.
>>
>> Patch by: Jeremy Whitlock <jcscoobyrs_at_gmail.com>
>> (Tweaked by me.)
>>
>> * subversion/libsvn_fs_fs/fs_fs.c
>> (recover_body): Check for missing or non-file revprops file for
>> youngest revision, and check that maximum rev is as expected.
>
> Forgive me if I'm missing something (including other mail --- I'm a
> few days behind), but I thought that making the youngest rev in the
> current file equal the maximum discovered rev is the *entire point* of
> FSFS svnadmin recover? If we error here, what does this command even
> do?

It's possible that the revprops file for that revision might be
missing, since the order of writes is revs, revpros, current. So if
we can't guarantee that all of a rev (except the current file) is
present, we don't update the current file to point to that rev.

(Or am I misunderstanding your question?)

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-08 04:51:42 CET

This is an archived mail posted to the Subversion Dev mailing list.