[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27098 - trunk/subversion/libsvn_fs_fs

From: Eric Gillespie <epg_at_google.com>
Date: Thu, 07 Feb 2008 14:30:03 -0800

"David Glasser" <glasser_at_davidglasser.net> writes:

> Does this fix it?
>
> [[[
> Followup to r27098: fix potential segfault by using pools correctly.
>
> * subversion/libsvn_fs_fs/fs_fs.c
> (svn_fs_fs__rev_get_root): Keep a string out of a pool that might
> be cleared.
> ]]]

Looks like it, but why allocate it twice? First you changed the
pool from which you allocate rev_str, then you pstrdup it when
adding to the cache.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-07 23:32:25 CET

This is an archived mail posted to the Subversion Dev mailing list.