Re: [PATCH] Fix svnserve gssapi (and likely some other sasl backends)

Eric Gillespie wrote:
> I actually have svnserve authenticating with Kerberos now; sweet!

That's great!

> It was a bitch and a half to setup though... Plus I had to deal
> with this bug. I'll see if I can improve notes/sasl.txt next.
>
> [[[
> Fix minor bug causing svnserve gssapi (and possibly other sasl
> backends) to deadlock, as the client never sends the response the
> server is looking for.
>
> * subversion/libsvn_ra_svn/cyrus_auth.c
> (try_auth): If sasl_client_step returns SASL_CONTINUE, we must
> send something to the server even if sasl_client_step set out
> to NULL; that just means we send the empty string, so do so.
> ]]]
>
> Index: cyrus_auth.c
> ===================================================================
> --- cyrus_auth.c (revision 29213)
> +++ cyrus_auth.c (working copy)
> @@ -465,6 +465,10 @@
> arg = svn_base64_encode_string(arg, pool);
> SVN_ERR(svn_ra_svn_write_cstring(sess->conn, pool, arg->data));
> }
> + else
> + {
> + SVN_ERR(svn_ra_svn_write_cstring(sess->conn, pool, ""));
> + }
> }
>
> if (!status || strcmp(status, "step") == 0)

Looks good to me.

-- 
Vlad
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org