[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] include error codes in error messages

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Wed, 06 Feb 2008 18:25:14 -0500

Branko Čibej <brane_at_xbc.nu> writes:
> C. Michael Pilato wrote:
>> Branko Čibej wrote:
>>> Another thing that strikes me is that the whole errror number,
>>> e.g. 200011 in the example above, is quite and completely useless;
>>> because you never *see* that number in the code! You see some
>>> constant + 11, so this display is quite useless for searching for
>>> the cause.
>>
>> That's what tools/dev/which-error.py is for!
>>
>> $ tools/dev/which-error.py 200011
>> 00200011 SVN_ERR_DIR_NOT_EMPTY
>> $
>
> Doh.

Note that it would easy to make which-error.py smart enough to DTRT
when handed either "200011" or a smaller number equal to (200011 -
APR_OS_START_USERERR).

If we do print "(svn error X)", I think we should make X be
ABS_ERROR_NUMBER - APR_OS_START_USERERR. Smaller numbers both save
horizontal space and are inherently less alarming.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-02-07 00:25:27 CET

This is an archived mail posted to the Subversion Dev mailing list.