Re: svnsync funniness with bdb repositories

Lieven Govaerts wrote:
>
>
> Hyrum K. Wright wrote:
>> Added to the issue tracker as issue #3079.
>>
>
> [..]
>
>>>
>>>> Can you successfully run the svnsync tests over svn with a bdb
>>>> repository?
>>> No. I get an failure in test 19:
>>>
>>> EXCEPTION: SVNUnexpectedStderr: ['subversion/libsvn_repos/hooks.c:228:
>>> (apr_err=165001)\n', "svnsync: Failed to start
>>> '/home/hwright/dev/svn-apache/subversion/tests/cmdline/svn-test-work/repositories/svnsync_tests-19-1/hooks/pre-revprop-change'
>>>
>>> hook\n", 'subversion/libsvn_subr/utf.c:632: (apr_err=22)\n', 'svnsync:
>>> Valid UTF-8 data\n', '(hex: 18)\n', 'followed by invalid UTF-8
>>> sequence\n', '(hex: fd 09 08)\n']
>>> Traceback (most recent call last):
>>> File
>>> "/home/hwright/dev/svn-apache/subversion/tests/cmdline/svntest/main.py",
>>> line 1059, in run
>>> rc = apply(self.pred.run, (), kw)
>>> File
>>> "/home/hwright/dev/svn-apache/subversion/tests/cmdline/svntest/testcase.py",
>>>
>>> line 121, in run
>>> return self.func(sandbox)
>>> File "./svnsync_tests.py", line 638, in no_author
>>> run_test(sbox, "no-author.dump")
>>> File "./svnsync_tests.py", line 114, in run_test
>>> run_sync(dest_sbox.repo_url)
>>> File "./svnsync_tests.py", line 56, in run_sync
>>> raise SVNUnexpectedStderr(errput)
>>> SVNUnexpectedStderr: ['subversion/libsvn_repos/hooks.c:228:
>>> (apr_err=165001)\n', "svnsync: Failed to start
>>> '/home/hwright/dev/svn-apache/subversion/tests/cmdline/svn-test-work/repositories/svnsync_tests-19-1/hooks/pre-revprop-change'
>>>
>>> hook\n", 'subversion/libsvn_subr/utf.c:632: (apr_err=22)\n', 'svnsync:
>>> Valid UTF-8 data\n', '(hex: 18)\n', 'followed by invalid UTF-8
>>> sequence\n', '(hex: fd 09 08)\n']
>>> FAIL: svnsync_tests.py 19: test copying revs with no svn:author
>>> revprops
>
> Hyrum,
>
> r28995 fixes this test with bdb. Can you check if it also fixes the
> other issues you encountered?

Seems to work. I was able to leaving it running overnight, and didn't
wake up to a crash. :)

I am still seeing a failure of svnsync test 23 with bdb, though:
$ ./svnsync_tests.py --fs-type bdb 23
Aborted (core dumped)
Traceback (most recent call last):
  File
"/home/hwright/dev/svn-javahl/subversion/tests/cmdline/svntest/main.py",
line 1059, in run
    rc = apply(self.pred.run, (), kw)
  File
"/home/hwright/dev/svn-javahl/subversion/tests/cmdline/svntest/testcase.py",
line 121, in run
    return self.func(sandbox)
  File "./svnsync_tests.py", line 657, in
move_and_modify_in_the_same_revision
    run_test(sbox, "svnsync-move-and-modify.dump")
  File "./svnsync_tests.py", line 93, in run_test
    svntest.actions.run_and_verify_load(sbox.repo_dir,
master_dumpfile_contents)
  File
"/home/hwright/dev/svn-javahl/subversion/tests/cmdline/svntest/actions.py",
line 203, in run_and_verify_load
    'load', '--force-uuid', '--quiet', repo_dir)
  File
"/home/hwright/dev/svn-javahl/subversion/tests/cmdline/svntest/main.py",
line 435, in run_command_stdin
    raise Failure
Failure
FAIL: svnsync_tests.py 23: test move parent and modify child file in
same rev

-Hyrum