[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix regression tests on Turkish locale

From: Marcel Gosselin <marcel.gosselin_at_polymtl.ca>
Date: 2007-12-24 15:17:24 CET

Ismail Dönmez a écrit :
> Monday 24 December 2007 15:58:18 tarihinde Carsten Koch şunları yazmıştı:
>
>> Ismail Dönmez wrote:
>> ...
>>
>>
>>> We discussed this in depth and I think the best fix is suggested by Peter
>>> Samuelson, attached patch against SVN trunk just does that.
>>>
>> Wait... From the strcasecmp man page:
>>
>> "The strcasecmp() function compares the two strings s1 and s2, ignoring the
>> case of the characters."
>>
>> So, IMHO it does not make any sense to compare the same word
>> with (except for the case) the same string twice.
>>
>>
>> if (strcasecmp(word, "committed") == 0)
>>
>> should have exactly the same effect as
>>
>> if ( strcasecmp(word, "committed") == 0 || strcasecmp(word, "COMMITTED")
>> == 0)
>>
>
> Not on Turkish locale, where lowercase of I is not i but ı (i-dotless).
>
> Regards,
> ismail
>
I am not a committer but I would suggest adding a comment in the code
explaining why you compare twice.

Marcel Gosselin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 24 15:17:54 2007

This is an archived mail posted to the Subversion Dev mailing list.