[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: dav_svn__update_report and resource-walk

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-12-20 14:04:32 CET

C. Michael Pilato wrote:
> David Glasser wrote:
>> On Dec 19, 2007 7:50 PM, Eric Gillespie <epg@pretzelnet.org> wrote:
>>> In tightening up the operational logging, I've encountered
>>> another mystery. dav_svn__update_report looks for
>>> "resource-walk" from the client, but I'm not really sure what
>>> that causes it to do. It doesn't really matter, though, as serf
>>> *never* sends this and neon has code in fetch.c:make_reporter to
>>> send it, but no make_reporter calls use it!
>
> [...]
>
>> I found this code a couple of months ago, was concerned about its
>> interaction with something new (depth?), and eventually realized it
>> was pretty dead. Wasn't sure what to do though.
>
> The resource walk was used at the end of 'switch' operations as a way for
> the client to rebuild the wc-props cache. It was later found to be lacking
> in certain situations, so we instead taught our clients to invalidate all
> the wc-props before doing the real switch work, and then repopulating them
> lazily as info became available. The server-side logic exists for
> compatability for older clients (who, by the way, won't know anything of the
> new depth support).
>
> (If this helps to explain things, perhaps you could take the above and slap
> it in as a comment at just the right spot in the code?)

Oh! All that said, a new non-official client (such as SVNKit) could still
request the resource-walk, so we *should* make it depth-aware.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Thu Dec 20 14:04:46 2007

This is an archived mail posted to the Subversion Dev mailing list.