[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: static linking broken in trunk since commit of clientstring feature

From: David Glasser <glasser_at_davidglasser.net>
Date: 2007-12-17 20:44:06 CET

On Dec 17, 2007 10:53 AM, Eric Gillespie <epg@pretzelnet.org> wrote:
> "David James" <james@cs.toronto.edu> writes:
>
> > Instead of reverting r28503, why don't you just move
> > subversion/libsvn_ra/clientstring.c to subversion/libsvn_subr ? This
> > will eliminate the circular dependency. libsvn_subr is a grab bag of
> > utilities anyway.
> >
> > If it turns out later that libsvn_ra_neon and libsvn_ra_serf need to
> > share more functions (and not just these two simple functions), we'll
> > want to go the whole way and create a "libsvn_ra_util" library,
> > similar to libsvn_fs_util. Right now, that seems like overkill though,
> > so I think the simple fix above will do.
> >
> > We can document the above thinking by adding a short comment to the
> > top of clientstring.c, so that folks will remember to create a new
> > library later if it is needed.
> >
> > (I've CC'd Max and epg to see if they have better ideas.)
>
> I agree there's no sense creating ra-util just yet. I'll move it today.

Some discussion on the IRC channel suggested adding a callback to the
svn_ra_callbacks table, and a field to the svn_client_ctx_t structure,
to allow pushing this data through to the RA layer without needing a
static variable.

This would be much more invasive, of course.

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 17 20:44:20 2007

This is an archived mail posted to the Subversion Dev mailing list.