Re: Passing unused opts to every command considered harmful

On Dec 17, 2007 9:51 AM, Brian W. Fitzpatrick <fitz@red-bean.com> wrote:
> If a user runs 'svn help add' and sees that it takes --username and
> --password, they're going to wonder what it's used for.
[and]
> You're missing the point. Having --username is very useful for people
> whose login id is different than their username in a Subversion
> repository.

Yeah, this makes sense to me. I can definitely see that --username
and --password can be confusing here.

(On the other hand, we don't throw an error when (say) users specify
--username/--password for working-copy-only
mkdir/copy/move/propset/propdel/propedit, even though it only uses
those args for the URL-based variant.)

I do still think that there's value to giving a simple way to say
"make this command non-interactive, no matter whether or not it
happens to have an interactive codepath in the", though. However,
hey, if there's enough disagreement with that, then sure, revert it; I
just wanted to explain my original reasoning, and don't really feel
strongly either way.

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org