[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Passing unused opts to every command considered harmful

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-12-17 09:53:53 CET

Branko Čibej <brane@xbc.nu> writes:
> Brian W. Fitzpatrick wrote:
>> While updating the reference chapter of the Subversion Book, I
>> discovered that suddenly *every* command has grown --username and
>> --password options. While some commands may now need authn for merge
>> tracking, I found it odd that *every* command did. A little rooting
>> around led me to this gem:
>>
>> /* Options that apply to all commands. (While not every command may
>> currently require authentication or be interactive, allowing every
>> command to take these arguments allows scripts to just pass them
>> willy-nilly to every invocation of 'svn') . */
>>
>> I will strongly resist every urge to be a poisonous person here, but
>> can someone please tell me why we should confuse millions of users
>> just to make life easier for scripts to pass things "willy-nilly" into
>> our Subversion client?
>>
>> I cannot believe that people find this to be acceptable. We're
>> putting developers first here, and users second.
>
> This looks like another ass-backw^W^Wunfortunate UI design decision. We
> used to be able to filter out such warts before they reached code.
> What's gone wrong?

Lapse in judgement and/or slipped through the review, it looks like.

I think it's fine to call this a bug (that comment notwithstanding),
remove the spurious option acceptances, and tell people to fix their
scripts if there's any fallout.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 17 10:06:05 2007

This is an archived mail posted to the Subversion Dev mailing list.