[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r28213 - in trunk/subversion: libsvn_client libsvn_wc tests/cmdline

From: David Glasser <glasser_at_davidglasser.net>
Date: 2007-12-04 02:10:47 CET

On Dec 3, 2007 12:24 PM, <pburba@tigris.org> wrote:
> Author: pburba
> Date: Mon Dec 3 12:24:18 2007
> New Revision: 28213
>
> Log:
> Finish issue #3029 by getting strict on what values ps svn:mergeinfo permits.
>

>
> Modified: trunk/subversion/libsvn_wc/props.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_wc/props.c?pathrev=28213&r1=28212&r2=28213
> ==============================================================================
> --- trunk/subversion/libsvn_wc/props.c (original)
> +++ trunk/subversion/libsvn_wc/props.c Mon Dec 3 12:24:18 2007
> @@ -2645,6 +2645,46 @@
> {
> new_value = svn_stringbuf_create_from_string(&boolean_value, pool);
> }
> + else if (strcmp(propname, SVN_PROP_MERGEINFO) == 0)
> + {
> + apr_hash_t *mergeinfo;
> + SVN_ERR(svn_mergeinfo_parse(&mergeinfo, propval->data, pool));
> + /* ### TODO: svn_mergeinfo_parse() conveniently performs almost all
> + the checks we require for valid svn:mergeinfo...except one, it
> + allows path's mapped to empty revision ranges. In addressing this
> + issue, http://subversion.tigris.org/issues/show_bug.cgi?id=3029, we
> + want to disallow this practice. But if we move enforcement of this
> + to svn_mergeinfo_parse() then anyone who has has mergeinfo created
> + by a pre-release version of 1.5 which has paths mapped to empty
> + ranges is in for a world of hurt. Why? Can't they simply tweak
> + their mergeinfo to follow the newly enforced rules? Sure, they
> + could, *if* they could see their mergeinfo...which they won't be
> + able to, since svn pl/pg will call svn_mergeinfo_parse() resulting
> + in an error.

Reeeeally? I could have sworn that svn_wc_canonicalize_svn_prop is
called only for propsets, on the new value only. (Note that it's not
actually called at commit time unless it's a propedit-on-URL, so it is
possible by working around the WC layer to commit invalid props
anyway...)

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 4 02:11:11 2007

This is an archived mail posted to the Subversion Dev mailing list.