[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] improve comment about extending svn_wc_entry_t

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: 2007-11-27 17:47:19 CET

Stefan Sperling wrote:
> Hi,
>
> can I commit this to trunk?

+1

-Hyrum

> [[[
> * subversion/include/svn_wc.h:
> (svn_wc_entry_t): Improve comment about extending svn_wc_entry_t,
> listing additional functions in entries.c that may need to be extended.
> ]]]
>
> Index: subversion/include/svn_wc.h
> ===================================================================
> --- subversion/include/svn_wc.h (revision 28068)
> +++ subversion/include/svn_wc.h (working copy)
> @@ -1581,9 +1581,7 @@
> */
> typedef struct svn_wc_entry_t
> {
> - /* IMPORTANT: If you extend this structure, check svn_wc_entry_dup()
> - and alloc_entry() in libsvn_wc/entries.c, to see if you need to
> - extend one or both of them as well. */
> + /* IMPORTANT: If you extend this structure, add new fields to the end. */
>
> /* General Attributes */
>
> @@ -1745,9 +1743,16 @@
> * @since New in 1.5. */
> svn_depth_t depth;
>
> - /* IMPORTANT: If you extend this structure, check svn_wc_entry_dup()
> - and alloc_entry() in libsvn_wc/entries.c, to see if you need to
> - extend one or both of them as well. */
> + /* IMPORTANT: If you extend this structure, check the following functions in
> + * subversion/libsvn_wc/entries.c, to see if you need to extend them as well.
> + *
> + * svn_wc_entry_dup()
> + * alloc_entry()
> + * read_entry()
> + * write_entry()
> + * fold_entry()
> + *
> + */
> } svn_wc_entry_t;
>
>

Received on Tue Nov 27 17:47:27 2007

This is an archived mail posted to the Subversion Dev mailing list.