Re: [patch] Use hash for optional args with long argument list in Ruby bindings

Hi kou,

On Nov 17, 2007 6:58 PM, Kouhei Sutou <kou@cozmixng.org> wrote:
> Hi,
>
> In <ae6cb1100711170750l282cc602j710ed8effe67705f@mail.gmail.com>
> "Re: [patch] Use hash for optional args with long argument list in Ruby bindings" on Sat, 17 Nov 2007 07:50:03 -0800,
> "Joe Swatosh" <joe.swatosh@gmail.com> wrote:
>
> > Okay, I committed in r27900. What about the :target_revision
> > argument? Couldn't
> > it reasonably be defaulted to zero?
>
> I think :target_revision isn't needed because it seems that
> :target_revision is for output. We should remove
> :target_revision from argument list.

When I tried to do this the test_switch_editor started failing

test_switch_editor(SvnWcTest)
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test\test_wc.rb:879:in
`test_switch_editor'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/wc.rb:125:in `_open'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/wc.rb:115:in `open_anchor'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test\test_wc.rb:876:in
`test_switch_editor':
<2> expected but was
<0>.

So maybe its not such a great idea.

>
> BTW, it seems that switch_editor has a bug. It uses
> get_update_editor2 not get_switch_editor2. Could you fix
> this too?
>

I can type the characters, but we don't have any tests for update_editor or
switch_editor, they were just copy-pasted from the 1.4 branch so if we change
it the whole reason for having it (to maintain compatibility with 1.4) seems
like it is shot.

--
Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org