[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix for issue #2982

From: Senthil Kumaran S <senthil_at_collab.net>
Date: 2007-11-13 15:25:49 CET

Hi Kamesh,

Thanks for the review. I am attaching a new patch along with the changes
which you have mentioned.

[[[
Fix issue #2982.

  Reflect dropped/renumbered revisions in modified svn:mergeinfo data

  * subversion/svndumpfilter/main.c
    (include): Include svn_mergeinfo.h
    (parse_baton_t): Add skip_missing_merge_sources boolean for the new
     option
    (skip_missing_merge_sources): New function to skip missing merge
     sources in mergeinfo
    (set_node_property): If we have svn:mergeinfo then skip missing merge
     sources in mergeinfo value
    (svn_opt_subcommand_t): Add --skip-missing-merge-sources subcommand
    (options_table): Add description for --skip-missing-merge-sources
     subcommand
    (cmd_table): Add the new subcommand --skip-missing-merge-sources
    (svndumpfilter_opt_state): Add skip_missing_merge_sources boolean for
     the new option
    (parse_baton_initialize): Initialize skip_missing_merge_sources
    (main): Add svndumpfilter__skip_missing_merge_sources to switch case

Patch by: Senthil Kumaran <senthil@collab.net>
]]]

Thank You.

--
Senthil Kumaran S
http://www.stylesen.org/
Kamesh Jayachandran wrote:
> 
> 
> Kamesh Jayachandran wrote:
>> Senthil,
>>
>> Please post the patch to list, so that commenting would be easier.
>> Comments,
>> 1)Please change '--adjust-mergeinfo' to 
>> '--ignore-missing-merge-sources' as the way it should be.
> 
> Rather it should be '--skip-missing-merge-sources'.
> 
>> 2)In 'adjust_mergeinfo_value' you have 'new_rangelist' and 
>> 'modified_rangelist', whereas you can do the revnum adjusting directly 
>> on 'rangelist'.
>>
>>
>> Apart from that patch looks fine.
>>
>> Thanks
>> With regards
>> Kamesh Jayachandran
>>
>> Senthil Kumaran S wrote:
>>> Hi,
>>>
>>> I ve attached a patch to fix issue #2982 here 
>>> http://subversion.tigris.org/nonav/issues/showattachment.cgi/793/2982-fix-v1.patch 
>>>
>>>
>>> The log message for the above patch is here 
>>> http://subversion.tigris.org/issues/show_bug.cgi?id=2982#desc8
>>>
>>> Thank You.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
>> For additional commands, e-mail: dev-help@subversion.tigris.org
>>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Tue Nov 13 15:26:05 2007

This is an archived mail posted to the Subversion Dev mailing list.