Perhaps we should revert r17238? And look closely at all uses of
svn_io_file_del_on_pool_cleanup...
--dave
On Nov 12, 2007 8:52 PM, David Glasser <glasser@davidglasser.net> wrote:
>
> On Nov 12, 2007 7:23 PM, David Glasser <glasser@davidglasser.net> wrote:
> >
> > On Nov 12, 2007 7:22 PM, David Glasser <glasser@davidglasser.net> wrote:
> > > On Nov 12, 2007 5:11 PM, Eric Gillespie <epg@google.com> wrote:
> > > > Eric Gillespie <epg@google.com> writes:
> > > >
> > > > > I have:
> > > > >
> > > > > 0 trunk-r27779% uname -a
> > > > > Darwin 8.10.1 Darwin Kernel Version 8.10.1: Wed May 23 16:33:00 PDT 2007; root:xnu-792.22.5~1/RELEASE_I386 i386 i386
> > > > > 0 trunk-r27779% mount
> > > > > /dev/disk0s2 on / (local, journaled)
> > > >
> > > > Also of interest:
> > > >
> > > > 1 trunk-r27779% ./subversion/tests/libsvn_subr/translate-test | grep FAIL
> > > > 1 trunk-r27779% ./subversion/tests/libsvn_subr/translate-test | grep FAIL
> > > > FAIL: lt-translate-test 18: expand author and rev
> > > > FAIL: lt-translate-test 33: unexpand rev and url
> > > > FAIL: lt-translate-test 35: lf_to_crlf; unexpand author
> > >
> > > So, what Eric is reporting is seemingly-random test failures in translate-test.
> > >
> > > I have binary-searched this issue (on the same machine Eric found this
> > > on) and it appears that before r17283, they consistently passed; after
> > > they consistently fail.
> >
> > (By "consistently fail" I mean "consistently, a random subset fails".)
> >
> >
> > > Unfortunately, r17283 is just a test change.
> >
> > --dave
> >
> >
> > --
> > David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
> >
>
> This fixes it. Dunno why.
>
> Index: subversion/libsvn_subr/subst.c
> ===================================================================
> --- subversion/libsvn_subr/subst.c (revision 27787)
> +++ subversion/libsvn_subr/subst.c (working copy)
> @@ -1727,7 +1727,7 @@
> /* For atomicity, we translate to a tmp file and
> then rename the tmp file over the real destination. */
> SVN_ERR(svn_io_open_unique_file2(&d, &dst_tmp, dst,
> - ".tmp", svn_io_file_del_on_pool_cleanup,
> + ".tmp", svn_io_file_del_none,
> pool));
>
> /* Now convert our two open files into streams. */
>
>
>
> --
> David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
>
--
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 13 06:27:49 2007