[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27614

From: Eric Gillespie <epg_at_pretzelnet.org>
Date: 2007-11-09 03:54:47 CET

Karl Fogel <kfogel@red-bean.com> writes:

> Eric Gillespie <epg@google.com> writes:
> >> +++ trunk/subversion/libsvn_repos/repos.c Tue Nov 6 00:12:55 2007
> >
> >> +apr_array_header_t *
> >> +svn_repos__capabilities_as_list(apr_hash_t *capabilities, apr_pool_t *poo
> l)
> >
> >> +void
> >> +svn_repos__set_capabilities(svn_repos_t *repos,
> >> + apr_array_header_t *capabilities)
> >
> > Please make these public; any network server needs them, not just
> > the two we bundle.
>
> Sounds reasonable to me. I may give the latter a POOL arg in that
> case, will think on it and try to DTRT.

Yes, good idea. How about returning svn_error_t * as well?

--
Eric Gillespie <*> epg@pretzelnet.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 9 03:54:56 2007

This is an archived mail posted to the Subversion Dev mailing list.