[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27700 - in trunk/subversion: svnadmin svndumpfilter

From: D.J. Heap <djheap_at_gmail.com>
Date: 2007-11-08 19:00:59 CET

On Nov 8, 2007 9:35 AM, Paul Burba <pburba@collab.net> wrote:
> Hi Blair,
>
> Not sure if you noticed or not, but this commit breaks the Win32
> buildbot (and my own box):
>
> http://www.mobsol.be/buildbot/win32-xp%20VS2005/builds/2736/step-Build/0
>
> I took a (admittedly brief) look but couldn't figure out how to stop the
> warning but permit a successful build.
>
> Are you able to build on Win32 with this change?
>

Breaking the function prototype out works for me -- something like:

typedef APR_DECLARE(apr_status_t) open_fn(apr_file_t **, apr_pool_t *);

static svn_error_t *
create_stdio_stream(svn_stream_t **stream,
                    open_fn fn,
                    apr_pool_t *pool)
{
  apr_file_t *stdio_file;
  apr_status_t apr_err = fn(&stdio_file, pool);

  if (apr_err)
    return svn_error_wrap_apr(apr_err, _("Can't open stdio file"));

  *stream = svn_stream_from_aprfile(stdio_file, pool);
  return SVN_NO_ERROR;
}

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 8 20:08:34 2007

This is an archived mail posted to the Subversion Dev mailing list.