[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27405 - trunk/subversion/libsvn_wc

From: David Glasser <glasser_at_davidglasser.net>
Date: 2007-11-07 02:06:14 CET

On 11/1/07, Karl Fogel <kfogel@red-bean.com> wrote:
> "David Glasser" <glasser@davidglasser.net> writes:
> >> We should pick one way and enforce it. I think the way to do that is:
> >>
> >> if (requested_depth != svn_depth_unknown)
> >> {
> >> svn_wc__ambient_depth_filter_editor(&editor, &edit_baton,
> >> editor, edit_baton,
> >> anchor, target, adm_access,
> >> requested_depth, pool);
> >> }
> >>
> >> ...and just ensure that it is written in such a way that that is safe!
> >> We'd change the calling code so that it wouldn't have the extra
> >> variables to hold the wrapper editor, and change the callee to not
> >> take a requested_depth parameter at all.
> >
> > OK, and we might as well leave out the requested_depth parameter while
> > we're at it?
>
> Yup, exactly.
>
> Note that you'll have to play some const games to get the in-out
> behavior with 'editor' and '&editor', but it should be doable.

r27640.

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 7 02:06:26 2007

This is an archived mail posted to the Subversion Dev mailing list.