[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27323 - trunk/subversion/libsvn_client

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2007-10-24 01:09:17 CEST

"David Glasser" <glasser@davidglasser.net> writes:

> On 10/23/07, C. Michael Pilato <cmpilato@collab.net> wrote:
>> David Glasser wrote:
>> >> + case svn_opt_revision_committed:
>> >> + case svn_opt_revision_working:
>> >> + case svn_opt_revision_base:
>> >> + case svn_opt_revision_previous:
>> >> + {
>> >> + svn_wc_adm_access_t *adm_access; /* ### FIXME local */
>> >
>> > Did you meant to leave that in?
>>
>> To be honest, I don't know what "FIXME local" even means. I didn't add it
>> myself, though.
>
> Oh, heh. I guess it's actually 5 years old. r27336.

I can explain... that was to remind me that having this function open
a local, i.e. temporary and read-only, view of the working copy is a
bit of a hack as it means that the information obtained could be
out-of-date even before the function returns, and also that if/when
the operation opens the working copy "for real" the same entries file
needs to be read a second time.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 24 01:09:40 2007

This is an archived mail posted to the Subversion Dev mailing list.