[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: check-swig-pl broken on trunk?

From: John Peacock <john.peacock_at_havurah-software.org>
Date: 2007-10-19 19:53:33 CEST

John Peacock wrote:
> I'll get this running today, so that by tonight I hope to be able to report
> where the failures started...

I was distracted slightly by trying to get Xen installed on my desktop
(so I could run the test suite in a VM without Subversion installed).
Turns out I need a lot more RAM to run Xen and even one additionaly
instance... ;-)

In any case, I finally got a binary search working and discovered that
it was this patch that broke the Perl bindings:

> ------------------------------------------------------------------------
> r26241 | kfogel | 2007-08-22 03:01:57 -0400 (Wed, 22 Aug 2007) | 25 lines
>
> Issue #2882: make 'commit --depth=foo' work.
>
> * subversion/include/svn_client.h, subversion/libsvn_client/commit.c
> (svn_client_commit4): Change recurse parameter to depth.
>
> * subversion/libsvn_client/client.h
> (svn_client__harvest_committables): Take depth instead of nonrecursive.
>
> * subversion/libsvn_client/commit_util.c
> (svn_client__harvest_committables): Take depth instead of nonrecursive.
> (harvest_committables): Same, and remove a longstanding TODO with a
> satisfying "*thwack*!".
> (svn_client__get_copy_committables): Pass svn_depth_infinity,
> not nonrecursive=FALSE, to harvest_committables.
>
> * subversion/svn/commit-cmd.c
> (svn_cl__commit): Pass opt_state->depth directly.
>
> * subversion/tests/cmdline/depth_tests.py
> (commit_propmods_with_depth_empty): New test.
> (test_list): Run it.
>
> * subversion/tests/cmdline/commit_tests.py
> (commit_nonrecursive): Adjust to expect the new behavior.

I'll try and take a look this weekend at exactly which chunk caused it
to break (I'm guessing the first)...

John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Oct 19 19:53:59 2007

This is an archived mail posted to the Subversion Dev mailing list.