[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: os.wait in svntest.main.copy_repos?

From: David Glasser <glasser_at_davidglasser.net>
Date: 2007-10-18 03:21:18 CEST

On 10/17/07, Blair Zajac <blair@orcaware.com> wrote:
> David Glasser wrote:
> > On 10/17/07, David Glasser <glasser@davidglasser.net> wrote:
> >> On 10/17/07, David Glasser <glasser@davidglasser.net> wrote:
> >>> On 10/17/07, Philip Martin <philip@codematters.co.uk> wrote:
> >>>> "David Glasser" <glasser@davidglasser.net> writes:
> >>>>
> >>>>> Oh, and also --parallel is broken: it makes a bunch of threads, each
> >>>>> of which call popen3 and then wait, but there's no guarantee that the
> >>>>> test they wait on will be the test they popen3'd.
> >>>> It also modifies an array in multiple threads without any locking; I
> >>>> posted a mutex patch but then gave up when I encountered the wait
> >>>> problem.
> >>> From searching, it does appear that .append on a list should be
> >>> atomic. However, I think we'll be happier if we just change it to use
> >>> Queue. Will work on that now...
> >> See r27264. In addition to only using explicitly synchronized data
> >> structures, I think the new design is conceptually cleaner, and it
> >> eliminates a lot of sleeps; seems to speed me up a small amount too.
> >> Unfortunately the wait issues still exist.
> >
> > Hopefully fixed the wait issues in r27266.
>
> Looking at INSTALL, we require Python 2.2 for Windows. Looking here:
>
> http://effbot.org/downloads/#subprocess
>
> they supply subprocess for Python 2.2 and 2.3. So we know that some versions of
> subprocess work on older versions of Python.
>
> So maybe we can just include subprocess in the test suite and use that. We just
> have to fall back to the popen2.Popen3() code for Python 2.{0,1} on non-Windows
> systems.

Yeah, subprocess should work on 2.2 out of the box: PEP 291.

And is there really much of a good reason to allow use of pre-2.2
Python on Unix? Python 2.2 was released on 21-Dec-2001, over two
years older than Subversion 1.0.0...

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 18 03:21:31 2007

This is an archived mail posted to the Subversion Dev mailing list.