[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [issue #2880] 'svn commit --changelist NO_SUCH_CHANGELIST' should warn

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: 2007-09-30 14:26:10 CEST

On 9/28/07, Daniel L. Rall <dlr@finemaltcoding.com> wrote:

> Oddly, 'commit' seems to handle changelists different than other commands,
> most of which use svn_client_get_changelist() to fill a list of changelist
> targets in the command-line client which is then fed to a library routine.
> 'commit', on the other hand, takes a changelist name and finds the changelist
> targets inside libsvn_client. Ben, what's the reasoning for this (e.g.
> structure of the commit harvesting logic)? Can/should we change this?

Most commands take a list of targets to work on, and thus use the
get_changelist() routine as a way of augmenting the target-list.

'svn commit', however, is unique in the way it searches the working
copy and harvests targets. cmpilato pointed out that in that case,
--changelist should act as a 'filter' on the harvested targets, rather
than an a-priori list of targets to grab.

I suppose we *could* change it, but ISTR there was an important reason
we didn't. Maybe cmike remembers?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Sep 30 14:26:25 2007

This is an archived mail posted to the Subversion Dev mailing list.