[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] For consistency mark some dates and strings for localization

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-09-14 03:22:25 CEST

Arfrever Frehtes Taifersar Arahesis <arfrever.fta@gmail.com> writes:
> So what do you think about this small, reduced patch, which I'm
> attaching now? As mentioned earlier, localization of dates in `svn
> ls -v` would be consistent with localization of dates in `ls -l`.

The patch below looks good to me -- I guess the translator would just
rearrange the % codes in whatever order was appropriate?

I'd prefer for someone more familiar with translation/localization
issues to agree before I commit, though, in case I'm missing something
obvious. Anyone?

-K

> [[[
> Mark dates for localization.
>
> * subversion/svn/list-cmd.c
>   (print_dirent): Mark dates for localization.
>
> Patch by: Arfrever Frehtes Taifersar Arahesis <arfrever.fta@gmail.com>
> ]]]
>
> Index: subversion/svn/list-cmd.c
> ===================================================================
> --- subversion/svn/list-cmd.c (revision 26580)
> +++ subversion/svn/list-cmd.c (working copy)
> @@ -87,12 +87,12 @@
> && apr_time_sec(dirent->time - now) < (365 * 86400 / 2))
> {
> apr_err = apr_strftime(timestr, &size, sizeof(timestr),
> - "%b %d %H:%M", &exp_time);
> + _("%b %d %H:%M"), &exp_time);
> }
> else
> {
> apr_err = apr_strftime(timestr, &size, sizeof(timestr),
> - "%b %d %Y", &exp_time);
> + _("%b %d %Y"), &exp_time);
> }
>
> /* if that failed, just zero out the string and print nothing */

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Sep 14 03:19:05 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.