[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: copy-on-update (was Re: svn commit: r26471)

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: 2007-09-06 19:41:39 CEST

On 9/6/07, David Glasser <glasser@davidglasser.net> wrote:
> On 9/5/07, Ben Collins-Sussman <sussman@red-bean.com> wrote:
> > On 9/5/07, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
> > > On Wed, Sep 05, 2007 at 01:49:05PM -0700, sussman@tigris.org wrote:
> > > > Merge copy-on-updates branch to trunk.
> > > >
> > >
> > > Nice. Does it work? (the only reason I ask is that you only added a
> > > single XFail test, so I'm not sure what the status of the branch is
> > > currently).
> >
> > No, the feature doesn't actually exist yet. All that branch work was
> > simply to change our internal architecture so that the behavior we
> > want *can* be written.
> >
> > The new behaviors are:
> >
> > * the server now supplies copyfrom arguments to add_file() during an
> > update, if applicable.
>
> Not quite caught up post-Burning-Man with dev@ mail, but: did you rev
> the update APIs yet to provide a boolean to turn this behavior on, or
> do we still need to do that? (Because old wc editor is stupid and
> totally ignores the copyfrom args, it is vital that a new server not
> try to send them to old clients.)

Not yet... it's definitely on my todo list. Old clients are worse
than stupid... I believe they abort() if they receive copyfrom args.

So yeah, a new client would have to *explictly* request the new
update-behavior from the server, and the server may or may not be able
to provide it.

Wanna help with this?

> > Another snafu: how do we know if an WC file is the file we want? For
> > example, if the server sends copyfrom args of "foo.c@7", and the
> > client notices that it has foo.c@8, how does it know if that's the
> > same thing? It makes me wish we had an RA call to do node-id
> > filesystem comparisons.
>
> Can't svn_ra_stat do that (and check the created_rev field)? Although
> I feel like I've said this on IRC several times and maybe there was
> some reason I was wrong :)
>

Yeah, ra_stat will answer this question, you're right. We just need
to get the algorithm correct.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 6 19:38:32 2007

This is an archived mail posted to the Subversion Dev mailing list.