[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] "." and "\n" not worth translating

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2007-08-30 23:52:33 CEST

On Aug 30, 2007, at 10:42 AM, Arfrever Frehtes Taifersar Arahesis wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hello,
> I was updating Polish translation and I found 2 funny strings
> marked for translation in subversion/svnsync/main.c:
> "." in line 744
> "\n" in line 848
> I think that these strings aren't worth translating.

Definitely, nice catch -- non-localization is consistent with the
behavior we have in the 'svn' command-line client (in response to
notifications).

> [[[
> * subversion/svnsync/main.c: Don't translate "." and "\n".
>
> Patch by: Arfrever Frehtes Taifersar Arahesis <arfrever.fta@gmail.com>
> ]]]

Thanks for including a log message! In the future, please include
the symbol names of the functions changed by your patch. :-)

For some reason, this patch was malformed in a couple spots:

> Index: subversion/svnsync/main.c
> ===================================================================
> - --- subversion/svnsync/main.c (revision 26392)
> +++ subversion/svnsync/main.c (working copy)
> @@ -741,7 +741,7 @@
> node_baton_t *fb = file_baton;
> edit_baton_t *eb = fb->edit_baton;
>
> - - SVN_ERR(svn_cmdline_printf(pool, _(".")));

...here...

> + SVN_ERR(svn_cmdline_printf(pool, "."));
> SVN_ERR(svn_cmdline_fflush(stdout));
>
> return eb->wrapped_editor->apply_textdelta(fb->wrapped_node_baton,
> @@ -845,7 +845,7 @@
> SVN_ERR(eb->wrapped_editor->close_directory(baton, pool));
> }
>
> - - SVN_ERR(svn_cmdline_printf(pool, _("\n")));

...and here.

> + SVN_ERR(svn_cmdline_printf(pool, "\n"));
>
> return eb->wrapped_editor->close_edit(eb->wrapped_edit_baton,
> pool);
> }

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 30 23:42:43 2007

This is an archived mail posted to the Subversion Dev mailing list.