Re: [PATCH] Follow on to r26229 for Ruby bindings

Hi,

2007/8/30, Joe Swatosh <joe.swatosh@gmail.com>:
> This clears up the intermittent test failures I was getting. They where due
> to the new inheritable member of svn_merge_range_t not being initialized.

Could you commit this patch?

Thanks,

--
kou
> The log message is awful, but I didn't want to leave anything out.  Edits
> appreciated.
>
> [[[
>
> Finish up the follow on to r26229 for the Ruby bindings.  r26228 added support
> for non-inheritable mergeinfo revision ranges.
>
> * subversion/bindings/swig/core.i
>   (Svn::Ext::Core::Svn_merge_range_t#initialize): Add a new svn_boolean_t
>   inheritable argument and use it to set the new inheritable member of
>   svn_merge_range_t.
>
> * subversion/bindings/swig/ruby/svn/core.rb
>   (Svn::Core::MergeRange#to_a): Add the new inhertitable member to the
>   returned array.
>
> * subversion/bindings/swig/ruby/test/test_client.rb
>   (SvnClientTest#test_merge, SvnClientTest#test_merge_peg): Update the
>   expected results that are representations of svn_merge_range_t structs so
>   they include the new inheritable member.
>
> * subversion/bindings/swig/ruby/test/test_core.rb
>   (SvnCoreTest#test_mergeinfo_parse): Update the expected results that are
>   representations of svn_merge_range_t structs so they include the new
>   inheritable member.  New assertions to demonstrate "non-inheritable" ranges.
>
>   (SvnCoreTest#test_mergeinfo_diff, SvnCoreTest#test_mergeinfo_merge,
>   SvnCoreTest#test_mergeinfo_remove, SvnCoreTest#test_mergeinfo_sort): Update
>   the expected results that are representations of svn_merge_range_t structs
>   so they include the new inheritable member.
>
>   (SvnCoreTest#test_mergeinfo_to_s): New assertions to demonstrate "non-
>   inheritable" ranges.
>
>   (SvnCoreTest#test_range_list_diff, SvnCoreTest#test_range_list_merge,
>   SvnCoreTest#test_range_list_remove, SvnCoreTest#test_range_list_intersect,
>   SvnCoreTest#test_range_list_reverse, SvnCoreTest#test_range_list_to_s):
>   Update the invocations of Svn::Core::RangeList.new to include the new
>   inheritable argument. Update the expected results that are representations
>   of svn_merge_range_t structs so they include the new inheritable member.
>
> * subversion/bindings/swig/ruby/test/test_ra.rb
>   (SvnRaTest#test_mergeinfo): Update the expected results that are
>   representations of svn_merge_range_t structs so they include the new
>   inheritable member.
>
> ]]]
>
> --
> Joe
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org