Re: [PATCH] Ruby bindings follow on to r26229

Hi,

Second try.

On 8/24/07, Kouhei Sutou <kou@cozmixng.org> wrote:
> Hi,
>
> In <ae6cb1100708232157j5273ab11mafaf61ba18a175b@mail.gmail.com>
> "Re: [PATCH] Ruby bindings follow on to r26229" on Thu, 23 Aug 2007 21:57:54 -0700,
> "Joe Swatosh" <joe.swatosh@gmail.com> wrote:
>
> > > >

> >
> > I have no idea how to do this. I'm interested to see how you accomplish it.
>
> Here is my idea (not tested):

> And here is my feature idea (pseudo code):
>

Ah, pretty obvious once you spelled it out for me. I took what you presented
here and implemented it more like svn_depth_t. Here we go:

[[[

Follow on to r26229 which added support for non-inheritable mergeinfo revision
ranges.

* subversion\bindings\swig\core.i
  (svn_swig_rb_mergeinfo_merge and svn_swig_rb_rangelist_merge): added new
  svn_merge_range_inheritance_t argument and forwarded to svn_mergeinfo_merge
  and svn_rangelist_merge respectively.

* subversion/bindings/swig/include/svn_types.swg
  (%typemap(in) svn_merge_range_inheritance_t): New typemap.

* subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.c,
  subversion/bindings/swig/ruby/libsvn_swig_ruby/swigutil_rb.h
  (svn_swig_rb_to_merge_range_inheritance): New conversion function.

* subversion\bindings\swig\ruby\svn\core.rb
  (Svn::Core::MergeInfo#diff, Svn::Core::MergeInfo#merge,
  Svn::Core::RangeList#diff, Svn::Core::RangeList#merge,
  Svn::Core::RangeList#remove) each got a new argument consider_inheritance
  which is defaulted to nil.

* subversion\bindings\swig\ruby\test\test_core.rb
  (SvnCoreTest#test_merge_info_to_s)

]]]

--
Joe

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org