[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: If no such changelist, show we error?

From: Talden <talden_at_gmail.com>
Date: 2007-08-19 22:57:21 CEST

> > If changelists are intended to hold paths rather than scheduled
> > changes then I'd have expected items to stay on changelists and for
> > changelists to be a feature of the working copy as a whole - allowing
> > a path to be listed on multiple changelists
>
> Er, um... you really don't want a path to be part of 2 changelists at
> once. That would imply two overlapping patches, and 'svn ci
> ---changelist cl1' wouldn't know which 'hunks' of patches to commit.
> This was a scenario we deliberately decided to avoid when we designed
> this fetaure.

Treating them 'as a patch' means that a changelist really _is_ 'a set
of scheduled changes' rather than a 'list of paths'. In that sense, a
commit of a path should _always_ clear the path from any changelist as
that change has been committed and cannot still be scheduled - it no
longer forms part of that patch.

Another alternative is to abort any commit that does not name a
changelist but contains 1 or more modified paths on changelists. This
way the user cannot accidentally break up a patch by failing to
specify the changelist and thus breaking up the patch they've already
defined. If the user doesn't use changelists this doesn't change
behaviour from pre changelist versions - but if they do it gives them
better protection from user error.

--
Talden
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Aug 19 22:55:01 2007

This is an archived mail posted to the Subversion Dev mailing list.