"David Glasser" <glasser@davidglasser.net> writes:
> On 8/18/07, Eric Gillespie <epg@pretzelnet.org> wrote:
> > "David Glasser" <glasser@davidglasser.net> writes:
> >
> > > certainly expect this to be a bug. I'd hope to see either no output
> > > or a warning if you call "svn ci --changelist foo" where foo has
> > > elements but has no committables, and an error if you call "svn ci
> > > --changelist footypo" where footypo has no elements at all.
> >
> > I would treat them both as equivalent to running 'svn ci' without
> > arguments in a clean working copy, i.e. silently exit 0.
>
> I agree on the former case (elements but no commitables). However, if
> we stick with the current behavior (which is what you describe), we
> have this inconsistency, which I find confusing:
>
> macbook-2:/tmp/x/w glasser$ $SVN diff
> macbook-2:/tmp/x/w glasser$ $SVN diff --changelist typo
> svn: Try 'svn help' for more info
> svn: no such changelist 'typo'
> macbook-2:/tmp/x/w glasser$ $SVN ci
> macbook-2:/tmp/x/w glasser$ $SVN ci --changelist typo
> macbook-2:/tmp/x/w glasser$
No, if the changelist doesn't exist, I agree we should error. I
was disagreeing that we should error if the cl does exist, but is
just empty.
cl has committables: commit them
cl has files but no committables: silently exit 0
cl has no files: silently exit 0
cl does not exist: error out
--
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Aug 18 21:18:14 2007