Re: [PATCH] Last two ra callbacks for Python binding

On 8/16/07, Eric Gillespie <epg@pretzelnet.org> wrote:
> "David James" <james@cs.toronto.edu> writes:
>
> > In order for this to work on old versions of APR where
> > sizeof(apr_off_t) == sizeof(long), you'll have to case this based on
> > sizeof(progress) and sizeof(long).
>
> Actually, how about this. We only had to worry about it with the
> format string because va_arg needs to know how many bytes to pull
> off the stack, but we know that whatever we have fits in a long
> long, so let's just convert up-front.

Looks good. Nice trick!

Cheers,

David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 17 19:55:43 2007