Re: svn commit: r26030 - trunk/subversion/svn

kameshj@tigris.org writes:
> + if (subcommand->cmd_func == svn_cl__switch)
> + {
> + if ((opt_state.depth != svn_depth_unknown) && opt_state.relocate)
> + {
> + err = svn_error_create(SVN_ERR_CL_MUTUALLY_EXCLUSIVE_ARGS, NULL,
> + _("--relocate and --depth are mutually "
> + "exclusive"));
> + return svn_cmdline_handle_exit_error(err, pool, "svn: ");
> + }
> + }

Is the outer condition really necessary? opt_state.relocate can't
even be set if this isn't the 'switch' command ... and if it *is* set,
that must mean it's the future and we've allowed that option on some
other command too, in which case this check would just get in the way.

Best,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Aug 16 22:29:59 2007