[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r26104 - trunk/subversion/libsvn_ra_svn

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-08-16 18:49:01 CEST

On Thu, 16 Aug 2007, David Glasser wrote:

> On 8/15/07, cmpilato@tigris.org <cmpilato@tigris.org> wrote:
> > Author: cmpilato
> > Date: Wed Aug 15 11:17:36 2007
> > New Revision: 26104
> >
> > Log:
> > * subversion/libsvn_ra_svn/client.c
> > (DEPTH_TO_RECURSE): Comment about why this exists at all.
>
> To be honest, I'm pretty sure that if I were reading code that uses
> this macro, I would entirely fail to notice the lack of SVN_ on the
> front, and might use the wrong one if editing the code. I'm not sure
> that I can suggest anything better though... RA_SVN_DEPTH_TO_RECURSE?
> </bikeshed>

I like the sound of an RA_ prefix there.

  • application/pgp-signature attachment: stored
Received on Thu Aug 16 18:46:48 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.