Re: [PATCH] fix for interactive merge-callback not supporting spaces in file paths

David Glasser wrote:
> On 7/25/07, C. Michael Pilato <cmpilato@collab.net> wrote:
>> Oooh... maybe I misremembered the reason we moved to system(). It was
>> wasn't because we wanted to support editor programs with spaces in their
>> paths, it was that the "editor" might have been defined as a program path
>> plus some arguments ('emacs -nw'). Right?
>
> Yes, and in fact even more than that (which can be dealt with the way
> that ra_svn's find_tunnel_agent does by tokenizing): the editor might
> be defined as something needing the full power of the shell, such as
> "HOME=/home/erik vi". (Whether or not this is an important case, it's
> something we've supported for a while and it would be unfortunate to
> break people's config files.)

Wow. To me, that crosses the line of Things We Could Reasonably Promise to
Support. But since we currently get it more-or-less for free, sobeit.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand